<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:freedesktop@behdad.org" title="Behdad Esfahbod <freedesktop@behdad.org>"> <span class="fn">Behdad Esfahbod</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - OpenType weight between 0 and 100 could result in assertion in FcWeightFromOpenType"
href="https://bugs.freedesktop.org/show_bug.cgi?id=82228">bug 82228</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - OpenType weight between 0 and 100 could result in assertion in FcWeightFromOpenType"
href="https://bugs.freedesktop.org/show_bug.cgi?id=82228#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - OpenType weight between 0 and 100 could result in assertion in FcWeightFromOpenType"
href="https://bugs.freedesktop.org/show_bug.cgi?id=82228">bug 82228</a>
from <span class="vcard"><a class="email" href="mailto:freedesktop@behdad.org" title="Behdad Esfahbod <freedesktop@behdad.org>"> <span class="fn">Behdad Esfahbod</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=82228#c2">comment #2</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=82228#c1">comment #1</a>)
> > Thanks. That's definitely a bug. I'm curious to know what numbers you see
> > in the fonts though. In the WPF Font Selection Model document, it suggest
> > that if the font value in the OpenType OS/2 table is 1 to 9, then multiply
> > it by 100. I think I agree with that. Now that you have seen this in the
> > wild, what kind of values are out there?
>
> To be honest only saw it through looking through source code changes,</span >
Oh that's really comforting to know someone's reading the code :).
<span class="quote">> haven't hit it with any fonts yet. Looks like my bug though is a duplicate,
> just noticed <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Assertion Failure with certain TrueType fonts"
href="show_bug.cgi?id=82220">bug 82220</a> which appears to be the same issue and has sample
> font attached that triggers it.</span >
Ok, I'll do a survey of fonts I have access to and adjust. Fix the crash for
now:
commit 01bb6978b6389852c5259b135af45ecdfe9f42f8
Author: Behdad Esfahbod <<a href="mailto:behdad@behdad.org">behdad@behdad.org</a>>
Date: Wed Aug 6 12:23:24 2014 -0400
Fix assertion failure
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Assertion Failure with certain TrueType fonts"
href="show_bug.cgi?id=82220">https://bugs.freedesktop.org/show_bug.cgi?id=82220</a>
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - OpenType weight between 0 and 100 could result in assertion in FcWeightFromOpenType"
href="show_bug.cgi?id=82228">https://bugs.freedesktop.org/show_bug.cgi?id=82228</a>
diff --git a/src/fcweight.c b/src/fcweight.c
index c62f807..313f3f2 100644
--- a/src/fcweight.c
+++ b/src/fcweight.c
@@ -45,7 +45,7 @@ static int lerp(int x, int x1, int x2, int y1, int y2)
{
int dx = x2 - x1;
int dy = y2 - y1;
- assert (dx > 0 && dy > 0 && x1 <= x && x <= x2);
+ assert (dx > 0 && dy >= 0 && x1 <= x && x <= x2);
return y1 + (dy*(x-x1) + dx/2) / dx;
}</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>