<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - Fix or improve docs on FcConfigAppFontAddDir or FcConfigAppFontAddFile return value" href="https://bugs.freedesktop.org/show_bug.cgi?id=86950#c10">Comment # 10</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - Fix or improve docs on FcConfigAppFontAddDir or FcConfigAppFontAddFile return value" href="https://bugs.freedesktop.org/show_bug.cgi?id=86950">bug 86950</a> from <a class="email" href="mailto:freedesktop@behdad.org" title="Behdad Esfahbod <freedesktop@behdad.org>"> Behdad Esfahbod</a> <pre>After the changes broke many clients, I reverted the AddDir() changes and left AddFont() in. commit 46ec6a52d4cc447cc3ff4a13b2067ecb76c9db2e Author: Behdad Esfahbod <<a href="mailto:behdad@behdad.org">behdad@behdad.org</a>> Date: Fri Jun 26 17:02:13 2015 -0700 Revert changes made to FcConfigAppFontAddDir() recently In 32ac7c75e8db0135ef37cf86f92d8b9be000c8bb the behavior of FcConfigAppFontAddFile/Dir() were changed to return false if not fonts were found. While this is welldefined and useful for AddFile(), it's quite problematic for AddDir(). For example, if the directory is empty, is that a failure or success? Worse, the false value from AddDir() was being propagated all the way to FcInit() returning false now. This only happened upon memory allocation failure before, and some clients assert that FcInit() is successful. With this change, AddDir() is reverted back to what it was. AddFont() change (which was actually in fcdir.c) from the original commit is left in.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>