[Fontconfig] fontconfig cleanup patch

Patrick Lam plam at MIT.EDU
Fri Sep 23 09:46:59 EST 2005


Behdad Esfahbod wrote:
> [sent this patch to Keith a while back.  resending here.]
> 
> Attaching the patch.
> 
> The theme is:
> 
>   - Cast sizeof to int, to shut up signedness warnings in comparison.
> 
>   - Add consts were appropriate.
> 
>   - Use char arrays instead of char pointers in static const
> structures.  Optimizes per-process memory and relocation time.
> It's a bit controversial, since hardcodes upper limit on the size
> of the strings, but gcc would nag if you break that limit.  I
> find it safe enough, YMMV :)

I committed everything but the code in fclang.c, because I couldn't
immediately see that the bound there was correct.

pat



More information about the Fontconfig mailing list