[Fontconfig] fontconfig: FcConfigAppFontAddDir () doesn't work right

[Patrick Lam]

Takashi Iwai wrote:
> At Wed, 08 Feb 2006 00:10:18 -0500,
> Patrick Lam wrote:
> 
>>Takashi Iwai wrote:
>>
>>>At Tue, 07 Feb 2006 17:03:30 -0500,
>>>Patrick Lam wrote:
>>>
>>>
>>>>Mike FABIAN wrote:
>>>>
>>>>
>>>>>See 
>>>>>
>>>>>http://bugzilla.novell.com/show_bug.cgi?id=148693
>>>>
>>>>I'm kind of concerned about this patch potentially bringing back the
>>>>issues we had a while back with 'fc-cache .' not doing the right thing,
>>>>so I can't commit it until I check that issue out.  In particular, if we
>>>>don't normalize before we add a directory, it seems like fc-cache .
>>>>might do the wrong thing.
>>>
>>>
>>>If you mean the removal of check in FcConfigAddFontDir(), feel free to
>>>revert that particular hunk.  It got removed just to take the original
>>>behavior back - i.e. to keep 100% compatibility with older versions.
>>
>>What I've committed doesn't directly modify FcConfigAddFontDir, but
>>changes FcDirScanConfig back to its previous behaviour: if it can't
>>normalize a directory, it scans anyway.
> 
> 
> I think that's the essential part of that patch.
> The directory scanned is not listed in the config list since it's
> called from FcConfigAppFontAddDir().

I think we agree.  Please check to see if there's anything you notice to
be missing from this patch; things seem to work on this front for me.

pat