[Fontconfig] Re: Patch: fix endless loop problem

Mike FABIAN mfabian at suse.de
Mon Jan 30 13:26:32 PST 2006


Patrick Lam <plam at MIT.EDU> さんは書きました:

> Mike FABIAN wrote:
>> Patrick Lam <plam at MIT.EDU> さんは書きました:
>> 
>> 
>>>Mike FABIAN wrote:
>>>
>>>>The return value of FcCacheReadString () is zero because the end of
>>>>the cache file has been reached but "name_buf" still contains the
>>>>previous contents, therefore it never breaks (by the way, it might be
>>>>a good idea to check the return value of the read () a few lines later
>>>>as well).
>>>
>>>Looks good to me.  I've committed this patch.  Maybe it'll help with the
>>>weird .fonts.cache-2 cyclic behaviour too.
>> 
>> Unfortunaly not. I still could reproduce the cyclic behaviour today
>> even with my patch applied.
>
> There was also some really bad behaviour with the global cache which I
> just fixed.  That should not have addressed the cyclic behaviour, but
> now the global caches might actually work again.

I cannot reproduce the cyclic problem now. Maybe fixed by accident.

-- 
Mike FABIAN   <mfabian at suse.de>   http://www.suse.de/~mfabian
睡眠不足はいい仕事の敵だ。



More information about the Fontconfig mailing list