<div dir="ltr">Please make the modified code MT-safety and good to attach the patch as the file or into the bugzilla next time.<div><br></div><div>Thanks,<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 28, 2013 at 9:20 PM, Laurentiu Palcu <span dir="ltr"><<a href="mailto:laurentiu.palcu@intel.com" target="_blank">laurentiu.palcu@intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
<br>
This patch will add a --sysroot option to fc-cache and fc-cat tools. More<br>
explanations have been included in the commit message of the patch itself.<br>
<br>
Please review the patch but bear in mind that I only took contact with fontconfig<br>
source code approx a week ago. So, even though I tried my best to respect the<br>
coding convention and existing API, there are things I might have missed.<br>
<br>
I tested the patch both locally and on target. That is, after I deployed the image,<br>
I re-run fc-cache (without sysroot) and saw that the generated cache was identical.<br>
<br>
I also ran the tools under valgrind and, apparently, there were no leaks introduced.<br>
<br>
I sent the changes within only one patch as it adds only one logical change. But, if<br>
you guys have other rules (one patch per file, etc.), let me know and I'll resend.<br>
<br>
That being said, please review/test the changes yourselves and let me know your<br>
concerns/thoughts/etc.<br>
<br>
Thanks,<br>
Laurentiu<br>
<br>
Laurentiu Palcu (1):<br>
Add sysroot option to fc-cache and fc-cat<br>
<br>
fc-cache/fc-cache.c | 57 ++++++++++++++++++-----<br>
fc-cat/fc-cat.c | 54 +++++++++++++++++----<br>
fontconfig/fontconfig.h | 6 +++<br>
src/fccache.c | 119 ++++++++++++++++++++++++++++++++++++++++-------<br>
src/fccfg.c | 32 +++++++++++++<br>
src/fcfreetype.c | 4 ++<br>
src/fcstr.c | 18 ++++++-<br>
7 files changed, 251 insertions(+), 39 deletions(-)<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.7.9.5<br>
<br>
_______________________________________________<br>
Fontconfig mailing list<br>
<a href="mailto:Fontconfig@lists.freedesktop.org">Fontconfig@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/fontconfig" target="_blank">http://lists.freedesktop.org/mailman/listinfo/fontconfig</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>Akira TAGOH
</div></div></div>