[fprint] Egistec ES603 Driver

Patrick Marlier patrick.marlier at gmail.com
Tue Aug 28 11:49:07 PDT 2012


Hi Bastien,

On 08/28/2012 02:24 PM, Bastien Nocera wrote:
> On Fri, 2012-08-24 at 16:10 -0400, Patrick Marlier wrote:
>>
>> Bastien: I have two testers (if I consider Sachin) where the device
>> works properly. I need to clean up few comments in the source file.
>> Also
>> I have some unused functions but these can be useful to improve the
>> driver later.
>> Do you think this is enough for this driver to be added to the
>> libfprint
>> mainstream?
>
> How is it different from the driver in:
> https://bugs.freedesktop.org/show_bug.cgi?id=47198
> ?
It is a different implementation. I asked Alex if we could merge the two 
implementations but he didn't have time to work on this so there is no 
merge coming yet. As far as I know, my implementation has some more 
features even if it could be improved.

> I don't mind merging drivers that aren't perfect, as long as the code is
> decent and readable, and you can follow up for bug fixes.
I hope my code is readable... but feel free to be harsh (well, not too 
much lol).

> Patches should be filed and attached in bugzilla, under the libfprint
> product, and we can start the review there.
I will attach my implementation into the previous bug report (hopefully) 
in the few next days. I would like to do some more code clean-up before.

Thanks.
--
Patrick


More information about the fprint mailing list