From i at zem7.ru  Thu Jul  9 17:31:40 2015
From: i at zem7.ru (=?UTF-8?B?0JrQvtC90YHRgtCw0L3RgtC40L0g0KHQtdC80LXQvdC+0LI=?=)
Date: Fri, 10 Jul 2015 04:31:40 +0400
Subject: [fprint] VFS0050 driver
Message-ID: <CAEZePmAOp1qjCd1AGppKhngHczgPYjkGBYVyEttuFAKmgyqhAw@mail.gmail.com>

Hello,

Recently I have managed to write working Validity VFS0050 driver with some
help of payden's source on github (https://github.com/payden/libfprint). I
made it from scratch, sniffing USB packets from windows' driver via
USBLyzer. Now it works very well for me without any crashes and with low
false negatives.

In a few days I will add USB errors checkings and cut out all debug parts.

Could you please take a look on it and if everything is OK add the driver
to the library?
My repo is here: https://github.com/zemen/libfprint

--
Kind regards,
Konstantin Semenov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/fprint/attachments/20150710/b1c8cac2/attachment.html>

From anarsoul at gmail.com  Thu Jul  9 20:29:03 2015
From: anarsoul at gmail.com (Vasily Khoruzhick)
Date: Thu, 9 Jul 2015 20:29:03 -0700
Subject: [fprint] VFS0050 driver
In-Reply-To: <CAEZePmAOp1qjCd1AGppKhngHczgPYjkGBYVyEttuFAKmgyqhAw@mail.gmail.com>
References: <CAEZePmAOp1qjCd1AGppKhngHczgPYjkGBYVyEttuFAKmgyqhAw@mail.gmail.com>
Message-ID: <CA+E=qVfvVEOR=iag2Wx0x4j5063nNp-oFSqE9vzDvsPFADRhJA@mail.gmail.com>

Hi Konstantin,

On Thu, Jul 9, 2015 at 5:31 PM, Константин Семенов <i at zem7.ru> wrote:
> Hello,
>
> Recently I have managed to write working Validity VFS0050 driver with some
> help of payden's source on github (https://github.com/payden/libfprint). I
> made it from scratch, sniffing USB packets from windows' driver via
> USBLyzer. Now it works very well for me without any crashes and with low
> false negatives.
>
> In a few days I will add USB errors checkings and cut out all debug parts.
>
> Could you please take a look on it and if everything is OK add the driver to
> the library?

1) You should use asynchronous libusb API. Using synchronous API is
not acceptable.
2) Please try to avoid using libusb_device_reset(). Find out how
Windows driver deinitializes the device
3) Move functions from header into *c file

> My repo is here: https://github.com/zemen/libfprint

4) Last but not least - you have to prepare proper git-formatted
patch. Clone libfprint git repo instead of creating new one, add your
changes, commit, push to github.

Regards,
Vasily

P.S. Please keep ML in CC.

> --
> Kind regards,
> Konstantin Semenov
>
> _______________________________________________
> fprint mailing list
> fprint at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/fprint
>