[Galago-commits] r2980 - in trunk/notification-daemon: . src/daemon

[galago-commits at freedesktop.org]

Author: chipx86
Date: 2007-04-29 01:04:54 -0700 (Sun, 29 Apr 2007)
New Revision: 2980

Modified:
   trunk/notification-daemon/AUTHORS
   trunk/notification-daemon/ChangeLog
   trunk/notification-daemon/NEWS
   trunk/notification-daemon/src/daemon/engines.c
Log:
Patch by driehuis to prevent quitting on theme engine failure. We now spit out an error and then fall back to the default theme. Closes ticket #128.


Modified: trunk/notification-daemon/AUTHORS
===================================================================
--- trunk/notification-daemon/AUTHORS	2007-04-29 08:02:49 UTC (rev 2979)
+++ trunk/notification-daemon/AUTHORS	2007-04-29 08:04:54 UTC (rev 2980)
@@ -8,6 +8,7 @@
 	Matt Walton <matthew at matthew-walton.co.uk>
 	Pawel Worach <pawel.worach at gmail.com>
 	Rodney Dawes <dobey at novell.com>
+	driehuis at playbeing.org
 
 Translators:
 	Dutch - Wouter Bolsterlee <uws+gnome at xs4all.nl>

Modified: trunk/notification-daemon/ChangeLog
===================================================================
--- trunk/notification-daemon/ChangeLog	2007-04-29 08:02:49 UTC (rev 2979)
+++ trunk/notification-daemon/ChangeLog	2007-04-29 08:04:54 UTC (rev 2980)
@@ -1,3 +1,10 @@
+Sun Apr 29 01:02:12 PDT 2007  Christian Hammond <chipx86 at chipx86.com>
+
+	* src/daemon/engines.c:
+	  - Patch by driehuis to prevent quitting on theme engine failure. We now
+	    spit out an error and then fall back to the default theme. Closes
+	    ticket #128.
+
 ==================== 0.3.7 ====================
 
 Tue Feb 27 23:19:00 PST 2007  Christian Hammond <chipx86 at chipx86.com>

Modified: trunk/notification-daemon/NEWS
===================================================================
--- trunk/notification-daemon/NEWS	2007-04-29 08:02:49 UTC (rev 2979)
+++ trunk/notification-daemon/NEWS	2007-04-29 08:04:54 UTC (rev 2980)
@@ -1,3 +1,8 @@
+version 0.3.8:
+	* Fixed a bug where we were quitting on theme engine failure, instead of
+	  falling back to the default theme engine. Patch by
+	  driehuis-at-playbeing.org. (Ticket #128)
+
 version 0.3.7 (27-February-2007):
 	* Fixed a compatibility issue with dbus-glib 0.72. Patch by Pawel Worach.
 	  (Bug #95)

Modified: trunk/notification-daemon/src/daemon/engines.c
===================================================================
--- trunk/notification-daemon/src/daemon/engines.c	2007-04-29 08:02:49 UTC (rev 2979)
+++ trunk/notification-daemon/src/daemon/engines.c	2007-04-29 08:04:54 UTC (rev 2980)
@@ -60,7 +60,7 @@
 	if (!g_module_symbol(engine->module, #name, (gpointer *)&engine->name)) \
 	{ \
 		/* Too harsh! Fall back to default. */ \
-		g_error("Theme doesn't provide the required function '%s'", #name); \
+		g_warning("Theme doesn't provide the required function '%s'", #name); \
 		goto error; \
 	}