Patches for Pachi game

[Hans de Goede]

Slava Semushin wrote:
> Hello all!
> 
> Debian/Ubuntu/FreeBSD has package for Pachi game [1].
> 
> I have made two patches for it and want get review and share these
> patches with all other maintainers.
> 
> 
> 1) http://git.altlinux.org/people/php_coder/packages/pachi.git?p=pachi.git;a=blob;f=pachi-alt-src-off-by-one_fix.patch
> 
> Patch fixes off-by-one error.
> 
> 
> 2) http://git.altlinux.org/people/php_coder/packages/pachi.git?p=pachi.git;a=blob;f=pachi-alt-warnigs-fix.patch
> 
> Patch fixes all warnings from -Wall with gcc4.3 (Patch "depends" from previous.)
> 
> Looks like this patch fixes one error where SDL_MapRGB() was forgotten:
> 
>  112 --- src/fx.c.orig
>  113 +++ src/fx.c
>  118 -    SDL_SetColorKey(fadeobject,SDL_SRCCOLORKEY,(fadeobject->format,0,255,0));
>  119 +    SDL_SetColorKey(fadeobject,SDL_SRCCOLORKEY,SDL_MapRGB(fadeobject->format,0,255,0));
> 

Yip, good catch.

Fedora also has 2 patches, which partially overlap (also fix some warnings), 
but partially are new:

http://cvs.fedoraproject.org/viewvc/devel/pachi/pachi-fixes.patch?revision=1.2

This patch adds support for making pachi sgid games, by opening 
/var/games/pachi.hs in rw mode and dropping the sgid rights as the first thing 
in main() (note Fedora has many similar patches for many games out of security 
concerns related to sgid games)

It also contains a number of warning fixes (I really should learn to split 
patches better).

http://cvs.fedoraproject.org/viewvc/devel/pachi/pachi-nosound.patch?revision=1.1

This is a patch which stops pachi from crashing when for some reason sound is 
not available. I just noticed I also snuck in a fix for the sgid games shared 
highscore code.

Regards,

Hans