Patches for Pachi game

[Hans de Goede]

Slava Semushin wrote:
> Hello all!
> 

Hi,

> Debian/Ubuntu/FreeBSD has package for Pachi game [1].
> 
> I have made two patches for it and want get review and share these
> patches with all other maintainers.
> 
> 
> 1) http://git.altlinux.org/people/php_coder/packages/pachi.git?p=pachi.git;a=blob;f=pachi-alt-src-off-by-one_fix.patch
> 
> Patch fixes off-by-one error.
> 
> 
> 2) http://git.altlinux.org/people/php_coder/packages/pachi.git?p=pachi.git;a=blob;f=pachi-alt-warnigs-fix.patch
> 
> Patch fixes all warnings from -Wall with gcc4.3 (Patch "depends" from previous.)
> 

Hmm, I've just been checking your changes to merge the relevant parts into the 
Fedora version and this does not seem a warning fix:

--- src/game.c.orig
+++ src/game.c
@@ -80,9 +80,6 @@ void check_exits() // esta funcion se fija si hay salidas 
disponibles
      if(y < R_max_y)
  	if(roommap[x][y+1]==stage)
  	    show_arrow(arrow_down, show);
-    if(y < 0)
-	if(roommap[x][y-1]==stage)
-	    show_arrow(arrow_up, show);
  }

  void stage_up()

More over it seems wrong, the right thing to do seems to change the "if(y < 0)" 
in to "if(y > 0)"

Regards,

Hans