[Glamor] [PATCH 7/9] Add compilation flag -Wall.

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 9 01:56:24 PST 2012


On Mon,  9 Jan 2012 13:36:09 +0800, zhigang.gong at linux.intel.com wrote:
> From: Zhigang Gong <zhigang.gong at linux.intel.com>
> 
> Signed-off-by: Zhigang Gong <zhigang.gong at linux.intel.com>
> ---
>  src/Makefile.am |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 5c5f7e5..393de63 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -15,7 +15,7 @@ instdir = $(moduledir)
>  INCLUDES = \
>  	$(XORG_INCS)
>  
> -AM_CFLAGS = $(XORG_CFLAGS) $(DIX_CFLAGS) $(LIBDRM_CFLAGS)
> +AM_CFLAGS = $(XORG_CFLAGS) $(DIX_CFLAGS) $(LIBDRM_CFLAGS) -Wall

Don't do this. Not only is this redundant as XORG_CFLAGS now includes
lots of warnings by default, but you did not check that the compiler
supports -Wall.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Glamor mailing list