[Glamor] [PATCH 1/9] glamor-composite: Optimize the computation of composite region.

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 9 02:22:46 PST 2012


I had a cursory read through of the series and agree wholeheartedly with
the changelogs -- just haven't analysed the actual changes to see if
they match with the intent. :)

Before I do, can you also consider adding glFinish to
glamor_block_handler(). If you start using firefxo, you will notice that
it can get quite laggy (and will become more apparent as you reduce the
overheads) - a sign that we are not throttling correctly. And as with
glamor we never expect to use the UXA block handler, there is no
mechanism for ensuring that the scanout gets flushed. I think the UXA
blockhandler should be run unconditionally just to ensure the regular
flush...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Glamor mailing list