[Glamor] (no subject)

Chris Wilson chris at chris-wilson.co.uk
Tue Jan 10 06:42:34 PST 2012


On Tue, 10 Jan 2012 13:21:48 +0800, zhigang.gong at linux.intel.com wrote:
> Add code to handle the memory allocation failure. Please review. Thanks.

You missed the advance of box, so you end up copying the first 10 boxes
every time in the case of an allocation failure. Also you now have the
value 10 hardcoded several times, if you make that ARRAY_SIZE(rect) it
becomes easier for when you change it from 10 to 32 etc.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Glamor mailing list