[Glamor] [PATCH v3] Add DRI3 support to glamor

[Gaetan Nadon]

On 13-12-09 03:59 PM, davyaxel at free.fr wrote:
>> In configure.ac:
>> > XORG_TESTSET_CFLAG([COMPAT_CFLAGS], [-Wc++-compat], [-Werror])
Just made a mistake here. We need two lines. The macro tests for a set
of flags, typically different for different compilers and pick the first
one that is accepted.

XORG_TESTSET_CFLAG([COMPAT_CFLAGS], [-Werror])
XORG_TESTSET_CFLAG([COMPAT_CFLAGS], [-Wc++-compat])

If we find a different option for another brand of compiler for
-Wc++-compat, then we add it to list.

>> >
>> > The flags will be added to the variable if they are supported. We never
>> > know for sure with which compiler our code gets built with. I think this
>> > is more than reasonable. Others will step-up to handle the few remainder
>> > cases if any
>> >
> Yep, expect we still have to use -Werror, to have the compilation failing in case there is a warning.
>
> I let you propose your configure.ac changes.