[Glamor] [PATCH 1/1] glamor: Fall back for unsupported picture format.

Michel Dänzer michel at daenzer.net
Thu Feb 6 10:35:33 CET 2014


On Die, 2014-02-04 at 18:52 -0500, Samuel Li wrote:
> This fixes seg fault when running x11perf -aa4trap300.
> 
> Signed-off-by: Samuel Li <samuel.li at amd.com>
> ---
>  src/glamor_pixmap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/glamor_pixmap.c b/src/glamor_pixmap.c
> index 84694ec..5de6325 100644
> --- a/src/glamor_pixmap.c
> +++ b/src/glamor_pixmap.c
> @@ -698,7 +698,7 @@ glamor_upload_sub_pixmap_to_texture(PixmapPtr pixmap, int x, int y, int w, int h
>  						   &swap_rb, 1)) {
>  		glamor_fallback("Unknown pixmap depth %d.\n",
>  				pixmap->drawable.depth);
> -		return TRUE;
> +		return FALSE;
>  	}
>  	if (glamor_pixmap_upload_prepare(pixmap, format, no_alpha, revert, swap_rb))
>  		return FALSE;

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer



More information about the Glamor mailing list