<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 13-12-06 11:00 AM, zhigang gong wrote: </div> <blockquote cite="mid:CAFfUhOXkmkYtbZZQMpadyQeq33eeTTEt0tsK74C+iZbxm+CE+g@mail.gmail.com" type="cite"> <div dir="ltr"> <div>LGTM, pushed, thanks for your contribution. </div> </div> <div class="gmail_extra"> <div class="gmail_quote">On Thu, Dec 5, 2013 at 3:49 PM, Axel Davy <<a moz-do-not-send="true" href="mailto:axel.davy@ens.fr" target="_blank">axel.davy@ens.fr</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This implements some DRI3 helpers to help the DDXs using glamor to support DRI3. Signed-off-by: Axel Davy <<a moz-do-not-send="true" href="mailto:axel.davy@ens.fr">axel.davy@ens.fr</a>> ---</blockquote> </div> </div> </blockquote> This patch introduces compile errors. I just did a full build of X from git and I get a dozen of errors in glamor_egl.c and a load of warnings. <blockquote>With libgbm: <tt><tt>../src/glamor_egl.c:236:45: error: 'GBM_FORMAT_ARGB8888' undeclared (first use in this function)</tt><tt> ../src/glamor_egl.c:466:38: error: 'GBM_BO_IMPORT_EGL_IMAGE' undeclared (first use in this function) ../src/glamor_egl.c:543:38: error: 'GBM_BO_IMPORT_EGL_IMAGE' undeclared (first use in this function) </tt> </tt>Without libgbm, some more:<tt> ../src/glamor_egl.c:236:32: error: 'struct glamor_egl_screen_private' has no member named 'gbm'</tt><tt> </tt><tt>../src/glamor_egl.c:237:11: error: 'GBM_BO_USE_RENDERING' undeclared (first use in this function)</tt><tt> </tt><tt>../src/glamor_egl.c:238:11: error: 'GBM_BO_USE_SCANOUT' undeclared (first use in this function)</tt><tt> </tt><tt>../src/glamor_egl.c:399:1: error: conflicting types for 'glamor_get_fd_from_bo'</tt><tt> </tt><tt>../src/glamor_egl.c:401:22: error: storage size of 'handle' isn't known</tt><tt> </tt><tt>../src/glamor_egl.c:414:1: error: conflicting types for 'glamor_get_name_from_bo'</tt><tt> </tt><tt>../src/glamor_egl.c:416:22: error: storage size of 'handle' isn't known</tt><tt> </tt><tt>../src/glamor_egl.c:513:29: error: 'DRM_FORMAT_ARGB8888' undeclared (first use in this function)</tt><tt> </tt><tt>../src/glamor_egl.c:543:31: error: 'struct glamor_egl_screen_private' has no member named 'gbm'</tt><tt> </tt></blockquote> When libgbm is missing, either protect the code or make it a requirement in the configuration. It's ok to abort the configuration if an important package is missing. You may want to add more checks if a particular version of libgbm is required. Here is a snippet of the autoconf configuration. <blockquote><tt>./autogen.sh --prefix $prefix [...] checking for XORG... yes checking for DRI2... yes checking whether to include GLAMOR_GLES2 support... no checking whether to include GLAMOR Xv support... yes checking whether to enable DEBUG... no checking for GL... yes checking for LIBDRM... yes checking for EGL... yes checking for GBM... yes checking Enable Glamor Dri3 helpers... yes checking for thread local storage (TLS) support... __thread checking for tls_model attribute support... yes </tt><tt> </tt></blockquote> </body> </html>