[Gstreamer-bugs] [Bug 99815] Changed - gstreamer should use ISO __VAR_ARGS__

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=99815

Changed by brian.cameron at ireland.sun.com.

--- shadow/99815	Fri Nov 29 05:04:16 2002
+++ shadow/99815.tmp.6075	Fri Nov 29 05:24:54 2002
@@ -207,6 +207,33 @@
                have_function=yes,
                have_function=no)])
                AC_MSG_RESULT($have_function)
                if test "$have_function" = yes; then
                        AC_DEFINE(HAVE_FUNCTION,1,[defined if gcc have
 HAVE_FUNCTION)])
+
+------- Additional Comments From brian.cameron at ireland.sun.com  2002-11-29 05:24 -------
+Yes, it looks like you are making the AC_DEFINE macros a bit nicer. 
+I've tested your changes on Solaris and verified that it still
+works great.  I think your change is good.
+
+By the way, do you have any idea how to address this issue that
+I'm still seeing? 
+             
+  gstinfo.c", line 182: syntax error before or at: __attribute__
+
+I notice that this website:
+
+http://www.redhat.com/mailing-lists/bochs-developers/msg00139.html
+
+seems to include the following patch in the source code to address
+a similar problem.  I'm not really clear what this __attribute__
+symbol is doing.  Does this seem a reasonable solution for gstreamer
+as well?
+
++ /*  gisburn 20010227: non-gcc compilers (like SUN Workshop 6)
+normally do not 
+      +have __attribute__ */
+      + #ifndef __GCC__
+      + #define __attribute__(x)
+      + #endif
+      +