[Gstreamer-bugs] [Bug 107186] Changed - [PATCH] - ffmpeg returns incorrect type for mp3's

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=107186

Changed by in7y118 at public.uni-hamburg.de.

--- shadow/107186	Mon Mar 31 03:12:30 2003
+++ shadow/107186.tmp.30630	Tue Apr  1 11:26:29 2003
@@ -28,6 +28,20 @@
 Created an attachment (id=14653)
 disable ffmpeg mpeg typefind
 
 
 ------- Additional Comments From Uraeus at linuxrising.org  2003-03-31 03:12 -------
 This patch should be merged before 0.6.1
+
+------- Additional Comments From in7y118 at public.uni-hamburg.de  2003-04-01 11:26 -------
+2 things:
+1) It's fixed in current ffmpeg cvs, so please don't apply to HEAD.
+(link to fix is http://cvs.sourceforge.net/cgi-
+bin/viewcvs.cgi/ffmpeg/ffmpeg/libavformat/mpeg.c.diff?r1=1.21&r2=1.22 
+- split by bugzilla)
+2) if you comment out some part of the code, please add a comment to 
+the source saying why you did so (like "disabling because ffmpeg 
+v0.x.y detects lots of mp3 files as video/mpeg") or someone else 
+might reenable it some day because he wonders why that line is 
+commented out.
+
+Someone please apply to 0.6 and close this bug.