[Gstreamer-bugs] [Bug 110757] Changed - [0.6.2] memory corruption fix

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=110757

Changed by rbultje at ronald.bitfreak.net.

--- shadow/110757	Tue Apr 15 00:06:32 2003
+++ shadow/110757.tmp.5062	Mon Apr 28 04:53:45 2003
@@ -1,22 +1,22 @@
 Bug#: 110757
 Product: GStreamer
 Version: HEAD CVS
 OS: other
 OS Details: 
-Status: ASSIGNED   
+Status: NEW   
 Resolution: 
 Severity: normal
 Priority: Normal
 Component: gstreamer (core)
-AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+AssignedTo: rbultje at ronald.bitfreak.net                            
 ReportedBy: vishnu at pobox.com               
 QAContact: gstreamer-maint at bugzilla.gnome.org
 TargetMilestone: 0.6.x
 URL: 
-Summary: memory corruption fix
+Summary: [0.6.2] memory corruption fix
 
 g_list_concat does _not_ copy the lists.  Folk, please read the
 documentation before using any library functions.
 
 ------- Additional Comments From vishnu at pobox.com  2003-04-14 09:29 -------
 Created an attachment (id=15708)
@@ -28,6 +28,35 @@
 registry/registrypool/plugin querying code.
 
 ------- Additional Comments From vishnu at pobox.com  2003-04-15 00:06 -------
 CVS HEAD appears to be fixed.  i'm not sure whether 0.6.1 needs a fix
 for this problem.  Otherwise, close this bug.
 
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2003-04-28 04:53 -------
+There's no gstregistrypool.c in 0.6.x. There is a gstregistry.c with
+the following code:
+
+GList*
+gst_registry_pool_plugin_list (void)
+{
+  GList *result = NULL;
+  GList *walk = _gst_registry_pool;
+                                                                     
+          
+  while (walk) {
+    GstRegistry *registry = GST_REGISTRY (walk->data);
+                                                                     
+          
+    /* FIXME only include highest priority plugins */
+    result = g_list_concat (result, g_list_copy (registry->plugins));
+                                                                     
+          
+    walk = g_list_next (walk);
+  }
+                                                                     
+          
+  return g_list_concat (_gst_registry_pool_plugins, result);
+}
+
+I'm assuming I need to use g_list_copy() on _gst_registry_pool_plugins
+here too?