[Gstreamer-bugs] [Bug 117897] Changed - New colorspace stuff

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=117897

Changed by ds at schleef.org.

--- shadow/117897	Sat Aug  2 19:22:19 2003
+++ shadow/117897.tmp.11851	Sat Aug  9 16:51:11 2003
@@ -91,6 +91,35 @@
 
 ------- Additional Comments From rbultje at ronald.bitfreak.net  2003-08-02 19:22 -------
 Oh, I forgot, there's one issue with RGB: the bytes aren't written in
 the right order in my fallback thing. However, I'm fairly sure that my
 byte-write code is correct. Anyone with some knowledge for
 endianness/RGB, please have a look and correct my stupidness.
+
+------- Additional Comments From ds at schleef.org  2003-08-09 16:51 -------
+Notes about the lcs code (imcomplete, made abuot a week ago)
+
+lcsarch.h:
+
+- defines should be in parens
+
+lcsfallback.c:
+
+- unsigned long long sucks as a type, use uint64_t
+
+- lcs_fallback_rgb_pixel_resample_component(): should multiply by
+  0x1001 (or whatever) instead of dividing.
+
+- this is the slowest code I've ever seen :)
+
+
+general:
+
+- IMO, clipping to [16,235]x[16,240]x[16,240] should be done
+  3-dimensionally.
+
+- magic constants for CCIR 601 -> RGB conversion should be
+  defines
+
+- make it possible to subclass LCSConverter, so that the individual
+  converters can cache information (or have a ->priv member)
+