[Gstreamer-bugs] [Bug 119550] Changed - useless comparison

bugzilla-daemon at widget.gnome.org bugzilla-daemon at widget.gnome.org
Sun Aug 10 07:55:26 PDT 2003


Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=119550

Changed by rbultje at ronald.bitfreak.net.

--- shadow/119550	Sun Aug 10 07:53:35 2003
+++ shadow/119550.tmp.3034	Sun Aug 10 10:55:26 2003
@@ -19,6 +19,13 @@
 gstreamer/libs/gst/bytestream/bytestream.c, line 277 has
 
 if (GST_BUFFER_OFFSET (headbuf) != -1)
 
 Which, since GstBuffer->offset is declared unsigned, could be replaced by
 if(1). It doesn't look sensible
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2003-08-10 10:55 -------
+I think it's checking for validity of the offset. An invalid offset is
+marked as (guint64) -1.
+
+Don't know why it does is this way, though, this is broken indeed, it
+seems...




More information about the Gstreamer-bugs mailing list