[Gstreamer-bugs] [Bug 119550] Changed - useless comparison

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=119550

Changed by in7y118 at public.uni-hamburg.de.

--- shadow/119550	Sun Aug 10 10:55:26 2003
+++ shadow/119550.tmp.31096	Thu Aug 14 03:37:32 2003
@@ -1,13 +1,13 @@
 Bug#: 119550
 Product: GStreamer
 Version: HEAD CVS
 OS: Linux
 OS Details: 
-Status: NEW   
-Resolution: 
+Status: RESOLVED   
+Resolution: FIXED
 Severity: normal
 Priority: Normal
 Component: gstreamer (core)
 AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
 ReportedBy: andjoh at rydsbo.net               
 QAContact: gstreamer-maint at bugzilla.gnome.org
@@ -26,6 +26,19 @@
 ------- Additional Comments From rbultje at ronald.bitfreak.net  2003-08-10 10:55 -------
 I think it's checking for validity of the offset. An invalid offset is
 marked as (guint64) -1.
 
 Don't know why it does is this way, though, this is broken indeed, it
 seems...
+
+------- Additional Comments From in7y118 at public.uni-hamburg.de  2003-08-14 03:37 -------
+That is legacy code from the time when offset was byte specific.
+I've removed it.
+
+If there's any breakage in plugins because of this, we'll find out
+soon enough.
+
+Thanks for pointing this out.
+
+btw: In comparisons between signed and unsigned ints the signed is
+always casted to unsigned. So this comparison would compare to
+G_MAX_UINT or so.