[Gstreamer-bugs] [Bug 114560] New - rfc2250enc produces empty buffers

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=114560

Changed by bugzilla.gnome.org at ralphm.ik.nu.

--- shadow/114560	Fri Jun  6 08:02:23 2003
+++ shadow/114560.tmp.5307	Fri Jun  6 08:02:23 2003
@@ -0,0 +1,37 @@
+Bug#: 114560
+Product: GStreamer
+Version: HEAD CVS
+OS: All
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: normal
+Priority: Normal
+Component: gst-plugins
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: bugzilla.gnome.org at ralphm.ik.nu               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: HEAD
+URL: 
+Summary: rfc2250enc produces empty buffers
+
+When hooking the rfc2250enc component (from the mpegstream plugin) up to an
+mpeg video source, the component sends over buffers with a payload of size
+0 (zero).
+
+To reproduce do:
+
+gst-launch -v filesrc location=myelementarympegstream.mpg ! rfc2250enc !
+fakesink dump=true
+
+The problem lies in gst/mpegstream/gstrfc2250enc.c, where the merging of
+buffers is done incorrectly in all cases, probably due to an (old) API
+change of gst_buffer_merge(). They way it is used, it is given 2 arguments,
+being the to-be-merged buffers. The context shows that it expects the
+result to be in the buffer given as the first argument, but the API says
+that the function  creates a new buffer and fills it with the concatenation
+of the two buffers and returns that.
+
+I have checked this by creating a new pointer variable and using that to
+collect the return value and using that in the code that follows it. This
+works as expected.