[Gstreamer-bugs] [Bug 116178] New - flacdec incorrectly finish the decoder at EOS

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=116178

Changed by tnt at 246tnt.com.

--- shadow/116178	Sat Jun 28 07:15:02 2003
+++ shadow/116178.tmp.7096	Sat Jun 28 07:15:02 2003
@@ -0,0 +1,34 @@
+Bug#: 116178
+Product: GStreamer
+Version: 0.6.2
+OS: All
+OS Details: Any
+Status: NEW   
+Resolution: 
+Severity: normal
+Priority: Normal
+Component: gst-plugins
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: tnt at 246tNt.com               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: HEAD
+URL: 
+Summary: flacdec incorrectly finish the decoder at EOS
+
+When an EOS is encountered ( in the datastream, not an EOS event of
+GStreamer), the decoder is finished with a call to
+FLAC__seekable_stream_decoder_finish ( line 471 of gstflacdec.c ), and the
+flag init is set to TRUE so that when a new stream is given, the decoder
+would be re-inited again and the decoding could take place.
+
+Unfortunatly the init flag only make a call to FLAC_..._init and this call
+WILL fail because with the finish call, all the options/callbacks have been
+resetted. ( If you look at the error code when this init happen, you'll
+receive error code 'Callbacks not set' ). So to fix this problem, you can
+replace the call to finish with a call to
+FLAC__seekable_stream_decoder_reset, and there is no need to set the init
+flag to true.
+
+In some cases ( when going from READY to PAUSED, ... ), an init will be
+performed on an already inited stream, with no consequence. The call fail
+but the decoder is left untouched.