[Gstreamer-bugs] [Bug 109069] New - Fix for X window leak in xvideosink plugin

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=109069

Changed by janzen at pixelmetrix.com.

--- shadow/109069	Mon Mar 24 02:44:48 2003
+++ shadow/109069.tmp.9144	Mon Mar 24 02:44:48 2003
@@ -0,0 +1,28 @@
+Bug#: 109069
+Product: GStreamer
+Version: 0.6.0
+OS: Linux
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: minor
+Priority: Normal
+Component: gst-plugins
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: janzen at pixelmetrix.com               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: 0.6.x
+URL: 
+Summary: Fix for X window leak in xvideosink plugin
+
+In sys/xvideo/xvideosink.c, the xvideosink->window pointer is not
+initialized to NULL.  Later in the code, there is the following
+commented-out code:
+
+  /* FIXME destroying the window causes a crash, so we'll let it leak for
+now */
+  /*_gst_xwindow_destroy (xvideosink->window);*/
+
+These are almost certainly related. :)  I've fixed the initialization and
+restored the _gst_xwindow_destroy() call, and everything seems to work fine
+for me.  See attached patch.