[Gstreamer-bugs] [Bug 123957] Changed - multidisksrc should emit its new-file signal even if it failed to open it

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=123957

Changed by rbultje at ronald.bitfreak.net.

--- shadow/123957	Tue Oct  7 08:05:39 2003
+++ shadow/123957.tmp.30768	Tue Oct  7 08:23:45 2003
@@ -91,6 +91,17 @@
 
 ------- Additional Comments From teuf at users.sourceforge.net  2003-10-07 08:05 -------
 For the record, there is more brokeness in the current code dealing
 with the new_file signal: the .h files say the signal handler will
 receive a gchar * corresponding to the new file name, while the code
 passes a GSList* when it emits the signal.
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2003-10-07 08:23 -------
+Subclassing of filesrc allows to use filesrc's file_open() and
+file_close() routines, which do all read()/mmap() bladiebla. They can
+also do the signalling, which would mean filesrc/multifilesrc use
+exactly the same signals. This should make multifilesrc's code a lot
+simpler, too.
+
+And for the record, the other multidisksrc bug is #122200.
+
+Thanks for the work, evne though you didn't subclass it. ;).