[Gstreamer-bugs] [Bug 121184] New - Assembly error in gst-libs/ext/ffmpeg/ffmpeg/libavcodec/bswap.h and common.h

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=121184

Changed by damien.carbery at sun.com.

--- shadow/121184	Mon Sep  1 10:56:30 2003
+++ shadow/121184.tmp.24471	Mon Sep  1 10:56:30 2003
@@ -0,0 +1,58 @@
+Bug#: 121184
+Product: GStreamer
+Version: 0.6.3
+OS: SunOS
+OS Details: Solaris 8 x86
+Status: NEW   
+Resolution: 
+Severity: critical
+Priority: Normal
+Component: gst-plugins
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: damien.carbery at sun.com               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: HEAD
+URL: 
+Summary: Assembly error in gst-libs/ext/ffmpeg/ffmpeg/libavcodec/bswap.h and common.h
+
+The Sun ONE Studio 8 compiler doesn't appear to like colons outside quotes
+in asm() code.
+
+Makefile and compiler output:
+cc -g -I/opt/gnome-2.4/include -g -DHAVE_AV_CONFIG_H -I..
+-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE -c -o common.o
+common.c 
+"bswap.h", line 11: syntax error before or at: :
+"bswap.h", line 26: syntax error before or at: :
+"bswap.h", line 36: syntax error before or at: __extension__
+"bswap.h", line 38: syntax error before or at: :
+"common.h", line 183: syntax error before or at: :
+"common.h", line 190: syntax error before or at: :
+cc: acomp failed for common.c
+make[6]: *** [common.o] Error 2
+make[6]: Leaving directory
+`/gnome/2.4/nightly/src-2.4-20030901/gst-plugins-0.6.3/gst-libs/ext/ffmpeg/ffmpeg/libavcodec'
+
+I think (example from bswap.h):
+ __asm("bswap	%0":
+      "=r" (x)     :
+can be changed to:
+  /* Put all text in quotes in separate statements. */
+ __asm("bswap	%0:" );
+ __asm("=r (x)     :" );
+but I know absolutely no assembly.
+
+In /usr/include/prof.h (only file in that dir with 'asm()'):
+#if defined(__i386)
+#define MARK(K) {\
+		asm("	.data"); \
+		asm("	.align 4"); \
+		asm("."#K".:"); \
+		asm("	.long 0"); \
+		asm("	.text"); \
+		asm("M."#K":"); \
+		asm("	movl	$."#K"., %edx"); \
+		asm("	call _mcount"); \
+		}
+#endif
+Note the individual statements and colons within quotes.