[Gstreamer-bugs] [Bug 121635] New - autogen.sh version checks fail on certain conditions

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=121635

Changed by mmenal at hurdfr.org.

--- shadow/121635	Sat Sep  6 18:06:41 2003
+++ shadow/121635.tmp.10914	Sat Sep  6 18:06:43 2003
@@ -0,0 +1,58 @@
+Bug#: 121635
+Product: GStreamer
+Version: 0.6.3
+OS: All
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: minor
+Priority: Normal
+Component: don't know
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: mmenal at hurdfr.org               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: HEAD
+URL: 
+Summary: autogen.sh version checks fail on certain conditions
+
+The gst-autogen.sh script used by GStreamer in two places does its
+version checks in a way that make them fail on certain conditions -
+specifically using the latest libtool available for Debian Unstable. The
+problem is that this line:
+
+pkg_version=`$COMMAND --version|head -n 1|sed 's/^.*) //'|sed 's/(.*)//'`
+
+.. assumes that there is only one set of parenthesis in the version line, which
+happens to be wrong in my case. (this is due to the fact that .* is greedy, so
+it will catch the first ')' without any trouble). Here is my version line :
+
+ltmain.sh (GNU libtool) 1.5.0a (1.1220.2.25 2003/08/01 19:08:35) Debian: 49 $
+
+And here is a simple patch for this :
+
+diff -Nurp gstreamer-0.6.3.old/common/gst-autogen.sh gstreamer-0.6.3/common/gst-autogen.sh
+--- gstreamer-0.6.3.old/common/gst-autogen.sh	2003-09-06 23:49:18.000000000 +0200
++++ gstreamer-0.6.3/common/gst-autogen.sh	2003-09-06 23:49:58.000000000 +0200
+@@ -63,7 +63,7 @@ version_check ()
+     # the following line is carefully crafted sed magic
+     # you don't want to mess with it
+     #pkg_version=`$COMMAND --version|head -n 1|sed 's/^[a-zA-z\.\ ()]*//;s/ .*$//'`
+-    pkg_version=`$COMMAND --version|head -n 1|sed 's/^.*) //'|sed 's/ (.*)//'`
++    pkg_version=`$COMMAND --version|head -n 1|sed 's/^[^)]*) //'|sed 's/ (.*)//'`
+     debug "pkg_version $pkg_version"
+     # remove any non-digit characters from the version numbers to permit numeric
+     # comparison
+diff -Nurp gstreamer-0.6.3.old/libs/ext/cothreads/common/gst-autogen.sh gstreamer-0.6.3/libs/ext/cothreads/common/gst-autogen.sh
+--- gstreamer-0.6.3.old/libs/ext/cothreads/common/gst-autogen.sh	2003-09-06 23:49:19.000000000 +0200
++++ gstreamer-0.6.3/libs/ext/cothreads/common/gst-autogen.sh	2003-09-06 23:50:07.000000000 +0200
+@@ -63,7 +63,7 @@ version_check ()
+     # the following line is carefully crafted sed magic
+     # you don't want to mess with it
+     #pkg_version=`$COMMAND --version|head -n 1|sed 's/^[a-zA-z\.\ ()]*//;s/ .*$//'`
+-    pkg_version=`$COMMAND --version|head -n 1|sed 's/^.*) //'|sed 's/ (.*)//'`
++    pkg_version=`$COMMAND --version|head -n 1|sed 's/^[^)]*) //'|sed 's/ (.*)//'`
+     debug "pkg_version $pkg_version"
+     # remove any non-digit characters from the version numbers to permit numeric
+     # comparison
+
+I guess sed isn't that magic. ;-)