[Gstreamer-bugs] [Bug 94113] Changed - spider doesn't detect type of mp3 stream

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=94113

Changed by rbultje at ronald.bitfreak.net.

--- shadow/94113	Mon Sep 29 10:37:12 2003
+++ shadow/94113.tmp.6837	Mon Sep 29 10:45:43 2003
@@ -270,6 +270,40 @@
 
 ------- Additional Comments From in7y118 at public.uni-hamburg.de  2003-09-26 10:46 -------
 *** Bug 119159 has been marked as a duplicate of this bug. ***
 
 ------- Additional Comments From rbultje at ronald.bitfreak.net  2003-09-29 10:37 -------
 *** Bug 115124 has been marked as a duplicate of this bug. ***
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2003-09-29 10:45 -------
+I've got a new typefind system! :).
+
+General explanation: instead of providing the typefind buffer with a
+buffer, we let it pull buffers itself, so it always has enough data.
+However, it doesn't read. Instead, it peeks, so we don't actually lose
+data (that'd kill playback after typefinding).
+
+typedef (GstCaps *) (* GstTypeFindFunc) (GstByteStream *bs, gpointer
+data);
+
+This has several effects:
+* bytestream is now part of the core
+* all plugins have been modified to use this new typefind system
+* asf typefinding added
+* mpeg video stream typefiding removed because it's broken
+* duplicate typefind entries removed
+* extra id3 typefinding added, because we've seen 4 types of files
+(riff/wav, flac, vorbis, mp3) with id3 headers and each of these needs
+to work. Instead, I've added an id3 element and let it redo typefiding
+after the id3 header. this needs a hack because spider only typefinds
+once. We can remove this hack once spider supports multiple typefinds.
+* with all this, mp3 typefinding is semi-rewritten
+* id3 typefinding in flac/vorbis is removed, it's no longer needed
+* fixed spider and gst-typefind to use this, too.
+* Other general cleanups
+
+Patches follow. The resulting system works for me locally. I'd love
+some people to test this. I want to commit this to HEAD asap.
+
+Apart from the patches below, gstreamer/libs/gst/bytestream/*,
+gst-plugins/gst/mpegaudioparse/gstmp3types.c,
+gst-plugins/gst/mpegtypes/gstmpeg[12]types.c can be removed.