[gstreamer-bugs] [Bug 158650] [videocrop] video crop is completely buggered [PATCH]

[bugzilla-daemon at bugzilla.gnome.org]

http://bugzilla.gnome.org/show_bug.cgi?id=158650
GStreamer | gst-plugins | Ver: HEAD CVS





------- Additional Comments From t.i.m at zen.co.uk  2004-12-11 13:08 -------
Created an attachment (id=34740)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=34740&action=view)
proposed patch

Patch that makes all of the above pipelines work for me. Most notably it:

 * updates the GST_VIDEO_I420_FOO() macros to those used elsewhere (note the
roundups, and the size macro)
 * fixes videocrop to allocate a properly-sized buffer for the output (used to
be too small at times because it didn't take into account rowstride padding)
 * fixes videocrop to use correct rowstrides when cropping and copying
 * sets source caps to original_video_size - cropping (not sure I've done it
the right way, but it seems to work and even survives ximagesink window
resizing)

Cheers
 -Tim


------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.