[Gstreamer-bugs] [Bug 135116] New - gstflacenc.c fails to build in NetBSD

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=135116

Changed by jmmv at menta.net.

--- shadow/135116	Sun Feb 22 08:32:50 2004
+++ shadow/135116.tmp.28041	Sun Feb 22 08:32:51 2004
@@ -0,0 +1,35 @@
+Bug#: 135116
+Product: GStreamer
+Version: HEAD CVS
+OS: NetBSD
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: major
+Priority: Normal
+Component: gst-plugins
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: jmmv at menta.net               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: HEAD
+URL: 
+Summary: gstflacenc.c fails to build in NetBSD
+
+The gstflacenc.c file fails to build under NetBSD, which aborts 
+gst-plugins build.  Here is the error: 
+ 
+gstflacenc.c: In function `gst_flacenc_chain': 
+gstflacenc.c:578: error: parse error before "void" 
+gstflacenc.c:613: error: parse error before "void" 
+gstflacenc.c:613: error: parse error before "void" 
+gmake[3]: *** [libgstflac_la-gstflacenc.lo] Error 1 
+ 
+This is caused by the way NetBSD defines the NULL symbol and how 
+gstreamer defines the GST_ELEMENT_ERROR macro; 
+from /usr/include/sys/null.h: 
+ 
+#define NULL (void *)0 
+ 
+One way to fix this is to patch gstflacenc.c to surround NULL with 
+parenthesis, when using the GST_ELEMENT_ERROR macro.  Another way is to 
+fix the macro itself to always surround the value.