[Gstreamer-bugs] [Bug 135640] Changed - Usage of alloca is not portable, and breaks under NetBSD

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=135640

Changed by wingo at pobox.com.

--- shadow/135640	Fri Feb 27 18:38:08 2004
+++ shadow/135640.tmp.30153	Sat Mar  6 08:59:35 2004
@@ -52,6 +52,19 @@
 Created an attachment (id=24873)
 Patch to switch from alloca to malloc
 
 
 ------- Additional Comments From ds at schleef.org  2004-02-27 18:38 -------
 Applied, thanks.
+
+------- Additional Comments From wingo at pobox.com  2004-03-06 08:59 -------
+The patch is somewhat OK. The thing with alloca is that it is really
+fast, so you can allocate memory from within the processing loop. The
+other choice is to allocate memory in the state-change function, or
+when a pad is added. I don't really consider malloc within the
+processing loop to be a viable option -- it is not realtime-safe,
+which is an eventual goal of gst.
+
+I don't think the author of the patch really understood this -- he
+failed to remove the comment describing alloca's use.
+
+So while the patch works, it is not correct. I will fix this later.