[Gstreamer-bugs] [Bug 143130] New: - [mixmatrix] returns garbage pointer as request pad

[bugzilla-daemon at bugzilla.gnome.org]

http://bugzilla.gnome.org/show_bug.cgi?id=143130
GStreamer | gst-plugins | Ver: HEAD CVS

           Summary: [mixmatrix] returns garbage pointer as request pad
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins
        AssignedTo: gstreamer-maint at bugzilla.gnome.org
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-maint at bugzilla.gnome.org


Mixmatrix returns random garbage pointers as request pads. Reproduce with: 
 
        mixmatrix = gst_element_factory_make ("mixmatrix", "mixmatrix"); 
        sinkpad = gst_element_get_request_pad (mixmatrix, "sink0"); 
        g_assert (GST_IS_PAD (sinkpad)); 
 
That's because the initial pads array is not initialised to NULL, so it just 
returns random garbage in the request pad function. 
 
Patch attached.  
 
There's more stuff that looks fishy to me, like: 
 
  mix->grpsize = 8; 
  mix->outsize = 1024; 
 
  // start with zero pads 
  mix->sinkpadalloc = mix->grpsize; 
  mix->srcpadalloc = mix->grpsize; 
 
but I couldn't be bothered to look into it further, as I found that I can't 
link the pads I get from deinterleave to the mixmatrix ones (the deinterleave 
pads have audio/x-raw-float caps with buffer-frames=(gint)0, and the mixmatrix 
request pads require buffer-frames >= 1). 
 
Cheers 
 -Tim

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the QA contact for the bug, or are watching the QA contact.