[gstreamer-bugs] [Bug 162974] [flacenc] Flac encoding is broken

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=162974
 GStreamer | gst-plugins | Ver: HEAD CVS





------- Additional Comments From zborgerd at gmail.com  2005-01-05 09:03 -------
There were a few callback changes in libFLAC since 1.1.1 was released.  Might
this have something to do with it?:

# Added new required tell callback on seekable stream encoder:

    * FLAC__SeekableStreamEncoderTellStatus and
FLAC__SeekableStreamEncoderTellStatusString[]
    * FLAC__SeekableStreamEncoderTellCallback
    * FLAC__seekable_stream_encoder_set_tell_callback()

# Changed FLAC__SeekableStreamEncoderState by adding
FLAC__SEEKABLE_STREAM_ENCODER_TELL_ERROR
# Changed Tell callback is now required to initialize seekable stream encoder



This is the code snippet in gstflacenc.c that seems to be failing:

 if (FLAC__seekable_stream_encoder_get_state (flacenc->encoder) ==
      FLAC__SEEKABLE_STREAM_ENCODER_UNINITIALIZED) {
    FLAC__SeekableStreamEncoderState state;

    FLAC__seekable_stream_encoder_set_write_callback (flacenc->encoder,
        gst_flacenc_write_callback);
    FLAC__seekable_stream_encoder_set_seek_callback (flacenc->encoder,
        gst_flacenc_seek_callback);

    FLAC__seekable_stream_encoder_set_client_data (flacenc->encoder, flacenc);

    gst_flacenc_set_metadata (flacenc);
    state = FLAC__seekable_stream_encoder_init (flacenc->encoder);
    if (state != FLAC__STREAM_ENCODER_OK) {
      GST_ELEMENT_ERROR (flacenc, LIBRARY, INIT, (NULL),
          ("could not initialize encoder (wrong parameters?)"));
      return;
    }


I think it's not initializing the seekable stream encoder as a result.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.