[gstreamer-bugs] [Bug 162306] [pngdec] does not decode all png files properly.

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=162306
 GStreamer | gst-plugins | Ver: HEAD CVS

algernon at bonehunter.rulez.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35609|0                           |1
        is obsolete|                            |



------- Additional Comments From algernon at bonehunter.rulez.org  2005-01-07 11:30 -------
Created an attachment (id=35620)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=35620&action=view)
Fixed patch implementing progressive PNG reading

Changes compared to my original patch:

in pngdec_info_callback(): Moved memory allocation after the caps stuff. If the
image is not appropriate, that gets handled while setting up the caps. Until we
do not know the memory is needed, don't allocate it - that is the reason.

in gst_pngdec_chain(): Do not destroy ->png_ptr and ->info, leave that to
->finalize (so that we don't try to destroy it twice, and won't be in trouble
if _chain gets called again immediately after an ERROR)

A ChangeLog entry is prepended before the actual diff.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.