[gstreamer-bugs] [Bug 163177] [pngdec] Can't cope with png's without an alpha channel

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=163177
 GStreamer | gst-plugins | Ver: HEAD CVS

algernon at bonehunter.rulez.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35582|0                           |1
        is obsolete|                            |



------- Additional Comments From algernon at bonehunter.rulez.org  2005-01-08 11:46 -------
Created an attachment (id=35670)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=35670&action=view)
Patch to fix the problem

Compared to the previous patch, this does:

Bail out earlier if encountering an image that has a bit_depth other than 8,
free resources and unref the buffer on error paths in gst_pngdec_chain(), and
add proper support for alpha channelled pngs. Instead of computing the length
of the row ourselves when setting up row pointers for libpng, the patch makes
pngdec use pngdec->info->rowbytes.

Also, in gst_pngdec_chain(), only allocate just enough memory, so we don't send
out too much data for nothing.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.