[gstreamer-bugs] [Bug 163323] [pngenc] compression-level customisation support

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=163323
 GStreamer | gst-plugins | Ver: HEAD CVS

algernon at bonehunter.rulez.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35715|0                           |1
        is obsolete|                            |



------- Additional Comments From algernon at bonehunter.rulez.org  2005-01-09 08:27 -------
Created an attachment (id=35724)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=35724&action=view)
Final patch

*sigh*

The updated patch is broken, it mixes g_param_spec_uint() with
g_value_(get|set)_int(), which is bad, and initializes ->compression_level to
-1 (Z_DEFAULT_COMPRESSION), which is also bad. And pngdec->compression_level
has a type of gint, which is not that bad, since it doesn't really matter as
the range is 0..9 anyway, but doesn't look nice.

This final patch corrects those problems.

(Now I go and hide in a cave until I learn to test my patches more carefully)

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.