[gstreamer-bugs] [Bug 162137] PostScript plugin

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=162137
 GStreamer | gst-plugins | Ver: HEAD CVS





------- Additional Comments From Maciej Katafiasz  2005-01-09 13:35 -------
Some comments:
1) PS <-> pnm doesn't look like most fortunate format choice, is there any
specific reason not to use video/x-raw-rgb? I don't think we even have any
plugin capable of dealing with pnm, unlike video/x-raw-rgb. So unless there's
some significant loss of functionality, change that to video/x-raw-rgb, and
leave manipulating pnm/png/jpeg their respective plugins.
2) Related to above, DON'T use property to choose output format. We have
filtered caps for that, you should be using those (and I still hold there should
be choice between at most vide/x-raw-rgb and video/x-raw-yuv, not other encoded
image formats)
3) Style fixes:
- mv gstpostscriptplugin.c gstpostscript.c, no need to specifically mark it's a
plugin, it's kinda obvious when it resides in gst-plugins ;)
- break long declaration lines, like 94 and following gstpostscriptdec.c, they
are *way* too long. Use general gstreamer/GNOME formatting rules
- I'd prefer s/Postscriptdec/PostscriptDec/, easier to read this way
- Also, postscriptdec is very typing-unfriendly, but I guess simply "psdec"
would have too high probability of clashes, right? Sigh, will need to live with that

Otherwise, from quick compile and run, it seems to work nice. Didn't have time
to look at source closely, will do sometime, preferably after the above
suggestions are incorporated :)

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.