[gstreamer-bugs] [Bug 163159] [videobox] plugin segfault (gst-plugin 0.8.7)

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=163159
 GStreamer | gst-plugins | Ver: 0.8.8





------- Additional Comments From David Wm. Parr  2005-01-12 14:24 -------
PROBLEM: The U & V row strides are different between the YUV420P format
generated by [videobox] (rowstride=330) and the YUV420P format used by
[ffcolorspace] (rowstride=332).  I don't know which is correct (conforms to the
YUV420P format).  Is the fix to correct the encoding of [videobox] or the
decoding of [ffcolorspace] ? 

The simple fix is to change
/home/dparr/gst/gst-ffmpeg-0.8.3/ext/ffmpeg/gstffmpegcodecmap.c:2267
  from: stride2 = ROUND_UP_4 (w2);
  to:   stride2 = w2;
However, I believe this is incorrect as this only works with [videobox] borders
of width 10; if you change to other or odd size borders, the calculations are
again incorrect.

Also - need more information on the X/Y chroma shift that is used in the
calculation; It would be a shame to fix YUV420 and then accidentally break all
of the 7 other formats processed by the same code

Assumptions: original video dimensions 640x480; videobox attempts to place a 10
pixel border all around, enlarging the dimensions of the frames passed to
[ffcolorspace] to 660x500

[videobox]
See gst_video_box_i420() in
/home/dparr/gst/gst-plugins-0.8.7/gst/videobox/gstvideobox.c
Y (660 x 500)
U (330 x 250)
V (330 x 250)

[ffcolorspace] 
See gst_ffmpeg_avpicture_fill() in
/home/dparr/gst/gst-ffmpeg-0.8.3/ext/ffmpeg/gstffmpegcodecmap.c
Y (660 x 500)
U (332 x 250)
V (332 x 250)



------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.