[gstreamer-bugs] [Bug 161675] [ffmpegcolorspace] conversion of RGB depth=15 is wrong

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=161675
 GStreamer | gst-plugins | Ver: HEAD CVS

Gergely Nagy changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36058|0                           |1
        is obsolete|                            |



------- Additional Comments From Gergely Nagy  2005-01-15 12:41 -------
Created an attachment (id=36062)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=36062&action=view)
Fixed patch

The previous patch did break RGB16.. Further inspection showed that RGB565 was
selected as the target colorspace instead of RGB555 (gst_ffmpeg_caps_to_pixfmt
only checked bpp which is 16, not depth which is 15).

Now, either bpp should be 15 (which is wrong, we use 16 bits to store it), or
depth should be checked too.

This patch adds code to gst_ffmpeg_caps_to_pixfmt does something like this:

if (bpp == 16) {
  pixfmt = RGB565;
  if (depth == 15)
    pixfmt == RGB555;
}

That should not break RGB16, and works on RGB15 (will need to test RGB16 some
way or the other.. any ideas?)

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.