[gstreamer-bugs] [Bug 149274] [PATCH] gst-plug mad gets id3v2 text tags in wrong encoding

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=149274
 GStreamer | gst-plugins | Ver: 0.8.2





------- Additional Comments From Tim-Philipp Müller  2005-01-21 07:52 -------
There is a spec for ID3v2 and always has been, and files like the above are 
clearly broken IMHO. 
 
But even _if_ one was to accept the approach you are taking, then the logic 
should at least be: 
 
  if (encoding == ID3V2_SPEC_ISO88591_REALLY_MEANING_LOCALE) 
  { 
     if (CURRENT_LOCALE == UTF-8) /* or any unicode really? */ 
     { 
        interpret_string_as_iso_8859_1(); 
     } 
     else 
     { 
        if (interpret_string_as_current_locale() == FAILED) 
          interpret_string_as_iso_8859_1(); 
     } 
  } 
 
 
I am not convinced, however, that this is the right approach. This approach 
has at least two problems: 
 
 * users tend to have files from multiple sources (friends, p2p networks, 
   or files from the days they still used Windows etc.), all of which 
   can be with strings encoded in whatever locale the source used. 
 
 * users might switch locales (e.g. consciously, or when upgrading their 
   distro, or when changing distros/OS etc.) 
 
 
I think the only semi-sane way to handle this problem is to have an 
environment variable like GSTREAMER_ID3_TAG_ENCODING that takes one or 
multiple ':'-separated encodings that are tried for ID3v2 strings in 
'iso-8859-1' encoding. 
 
Or someone should just write a small and easy-to-use app that converts those 
broken tags into unicode tags ;) 
 
Cheers 
 -Tim 
 
 
 

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.