[gstreamer-bugs] [Bug 311491] New: ogg muxer can get pages out of order (patch)

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=311491
 GStreamer | gst-plugins | Ver: 0.8.10

           Summary: ogg muxer can get pages out of order (patch)
           Product: GStreamer
           Version: 0.8.10
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: msmith at fluendo.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: all-bugs at bugzilla.gnome.org


If a page has a granulepos of -1 (indicating that no packets end on it), the ogg
muxer can get some data out of order. This hasn't come up before because a
libogg bug meant that the pages usually didn't have granulepos -1 even when they
should have.

This happens because the muxer selects the logical stream to write data from as
whichever stream has a page with the lowest timestamp. It only does this once
pages are available on queues for all the streams, so that this decision can be
done correctly (unless the stream is at EOS). However, it's actually neccesary
to check that the queues contain a page _with a timestamp_ - requiring some
lookahead. 

I'll shortly attach a patch that fixes this.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.