[gstreamer-bugs] [Bug 307394] New: Docs for gst_tag_setter_get_list are inconsistent

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=307394
 GStreamer | documentation | Ver: 0.8.10

           Summary: Docs for gst_tag_setter_get_list are inconsistent
           Product: GStreamer
           Version: 0.8.10
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: documentation
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: kaffeetisch at gmx.de
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: all-bugs at bugzilla.gnome.org


The docs for gst_tag_setter_get_list show G_CONST_RETURN for the returned tag
list, but also say it is to be freed with gst_tag_list_free() after use.  Those
two statements conflict with eachother.  Looking at the code:

  return gst_tag_setter_get_data (setter)->list;

it seems to me that the list shouldn't be freed, but I'm not sure.  In case this
is correct, here's a patch that changes the docs and the prototype to reflect
the situation.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.