[gstreamer-bugs] [Bug 307606] New: gstplaybasebin leaks mutex

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=307606
 GStreamer | gst-plugins | Ver: HEAD CVS

           Summary: gstplaybasebin leaks mutex
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: pborelli at katamail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: all-bugs at bugzilla.gnome.org


<disclaimer>clueless about GStreamer internals</disclaimer>

valgrind tells me[1] that gstplaybasebin leaks the mutex... from a quick look at
the code I see that gstplaybasebin implements dispose but not finalize: I think
it should implement finalize instead of dispose (dispose may run more than once)
and use finalize to free both the strings currently freed in dispose and the mutex.

Patch follows: UNTESTED


[1]:
==27776== 24 bytes in 1 blocks are definitely lost in loss record 8213 of 14968
==27776==    at 0x3414A5C1: malloc (vg_replace_malloc.c:131)
==27776==    by 0x35192136: IA__g_malloc (gmem.c:137)
==27776==    by 0x35132512: g_mutex_new_posix_impl (gthread-posix.c:151)
==27776==    by 0x35BC037F: gst_play_base_bin_init (gstplaybasebin.c:251)
==27776==    by 0x350EDECA: IA__g_type_create_instance (gtype.c:1588)
==27776==    by 0x350D97CE: g_object_constructor (gobject.c:1052)
==27776==    by 0x3446A2E7: gst_object_constructor (gstobject.c:197)

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.