[gstreamer-bugs] [Bug 169111] GstEvent NEED_RESPONSE flag

bugzilla-daemon at bugzilla.gnome.org bugzilla-daemon at bugzilla.gnome.org
Thu Mar 3 10:12:15 PST 2005


Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=169111
 GStreamer | gstreamer (core) | Ver: 0.8.9





------- Additional Comments From Ronald Bultje  2005-03-03 13:12 -------
Please don't create macros for flag setting, GST_DATA_* already has those. We
use the same principles for GstObject and derived.

First lines of sys/ximage/ximagesink.c:

+  ximagesink->need_expose = FALSE;  /* Set the need_expose flag. If it's clear
by the time we 
+   * get to put the image, the stream beat us to it
+   */
+  ximagesink->need_expose = TRUE;

why?

for sys/xvimage/xvimagesink.c, don't add/remove newlines, indentation, etc.
Apart from that, looks OK.


------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.




More information about the Gstreamer-bugs mailing list