[gstreamer-bugs] [Bug 151192] [PATCH] nsf decoder

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=151192
 GStreamer | gst-plugins | Ver: HEAD CVS





------- Additional Comments From Ronald Bultje  2005-03-26 15:56 -------
Created an attachment (id=39296)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=39296&action=view)
fixed version

Johan, you added compile fixes for type referencing, but forgot to assign
variables. what happens, is that this:

char buffer;
for (i = 0; i < large_number; i++) {
  if (16bit) {
    (*(int16*)buffer)++ = x;
  } else {
    (*(uint8*)buffer)++ = (x>>8)^0x80;
  }
}

becomes this:

char *buffer;
for (i = 0; i < large_number; i++) {
  if (16bit) {
    int16 *t = buffer;
    *t++ = x;
  } else {
    uint8 *t = buffer;
    *t++ = (x>>8)^0x80;
  }  
}

with the side-effect that you continuously write into the first byte of the
buffer. Took me a while to figure that out. Anyway, it works now, also in
Totem. However, the multi-tune thing is annoying, because apps such as Totem
cannot really handle that. Also, it silences after EOS. How do I handle that? I
don't want to apply it like this yet.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.