[gstreamer-bugs] [Bug 321269] add sunaudio to 0.9

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=321269
 GStreamer | gst-plugins-good | Ver: HEAD CVS





------- Additional Comments From Brian Cameron  2005-11-21 20:40 -------
Mike, thanks for reviewing this...

1) Yes, the rate should be 48000.  I hardcoded it to 44100 for testing purpopes  
  (to see if that would fix the problem with esdsink having trouble playing 
  certain WAV files (but it didn't).  It should be changed to 48000.

2) AUDIODEV is a Sun specific feature that supports SunRay hardware, which 
   has multiple terminals connected to a single server.  ESD also has similar
   logic.  Most audio programs that work on Sun have this logic to support
   SunRay.  If you think it is useful to make more general, than this could
   be done I suppose.

3) I copied the "get_caps" logic from the esdsink, which also doesn't seem
   to be ever freeing the caps structure.  How should this logic work to avoid
   leaking.  Should a "caps" pointer be placed in the GstSunAudioSink
   structure and copied once in the init function and just re-used?  The 
   esdsink should probably also be fixed.

4) I open non-blocking just because esd does this in their Solaris specific
   code.   I assumed it was necessary or they wouldn't be bothering doing
   it.

5) Regarding the open/reopen on unprepare and the close in reset, I just
   am doing this because it looked like it was what osssink did.  I can
   remove these calls, but am unsure how to test and verify that it is 
   working.  If I remove these calls and just test it with a few pipes
   that play OGG/WAV/AU/etc. files and it seems to work, then do I know it
   is working or do I need to do something more to test this?

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.