[gstreamer-bugs] [Bug 321269] add sunaudio to 0.9

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Tue Nov 22 00:59:50 PST 2005


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=321269
 GStreamer | gst-plugins-good | Ver: HEAD CVS





------- Additional Comments From Michael Smith  2005-11-22 08:59 -------
1. Ok, no problem, easy change then.

2. If this is a standard feature, fine.

3. You're leaking pad_template, not the pad itself. I think you just need to do
gst_object_unref (pad_template) after you're done using it.

4. Well, either the non-blocking open is unneccesary, or it's neccesary but
there's a race condition. But this doesn't need to block the plugin going in to
CVS, since it's a tricky issue.

5. My reading of osssink suggests it doesn't close in reset(). In fact, it does
nothing. osssink does close/reopen in unprepare, but I don't think that's needed
on SunAudio, it's a quirk of the OSS interface. Also, I'd assume it'd open
another close/reopen race, see 4.

All of these look like they should be trivial to do and give a quick test (if
not test exhaustively - but heavier testing can go on after it goes into cvs). 

Would you be able to do that, and file an updated patch? If you manage to do it
today (and I'll understand if you can't), we can probably get it into 0.9.6,
otherwise it'll go into the following (final?) 0.9.x release.


------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.




More information about the Gstreamer-bugs mailing list