[gstreamer-bugs] [Bug 315550] [typefinding] wrongly identifies non-music files as music files

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=315550
 GStreamer | gst-plugins | Ver: 0.8.x

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|don't know                  |gst-plugins
         Resolution|                            |FIXED
            Summary|Import folder imports non-  |[typefinding] wrongly
                   |music files                 |identifies non-music files
                   |                            |as music files
   Target Milestone|HEAD                        |0.8.12



------- Additional Comments From Tim-Philipp Müller  2005-10-09 18:43 -------
Part of this is a GStreamer bug, but part of this is also clearly a rhythmbox
bug though (IMHO).

Why does rhythmbox import files it can't get a length for (where the time column
says 'Unknown')? That doesn't really seem right to me. It should probably also
just skip all files that have a length smaller than 2 or 3 seconds, just to weed
out some more files that are most likely false positives.


I've now added typefinding for DLLs/.a files and some more archive formats, that
should at least skip some of the files in the screenshot:

2005-10-09  Tim-Philipp Muller  <tim at centricular dot net>

        * gst/typefind/gsttypefindfunctions.c: (tar_type_find),
        (ar_type_find), (msdos_type_find), (plugin_init):
          Add typefind functions for tar archives, ar archives,
          RAR archives, and ms-dos executables (dlls, exe, etc.).
          Some of these would wrongly be identified as mpeg
          streams of some sort before (#315550).


You might want to file a bug for rhythmbox to improve their importer if they
haven't done that yet.

 Cheers
  -Tim


------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.